Avoid need for dedicate product definitions for pde.build.tests#1840
Avoid need for dedicate product definitions for pde.build.tests#1840HannesWell merged 1 commit intoeclipse-pde:masterfrom
Conversation
HannesWell
force-pushed
the
replace-sdk.test.ide
branch
from
7f1bb0e to
4599390
Compare
|
Please test that the build actually fails if one of the test have a failure (as this was a problem before). Beside that I'm not sure if its good to depend on products provided elsewhere... this requires to always take care not to break something on changes. |
It's a valid concern That being said though, the Platform is an upstream project and this product definition is quite often reused downstream... |
Sure, no problem. What kind of change to test this do you have in mind? Just change an assertion?
It's right, that changes from upstream can be a problem, but it can also be beneficial if we inherit e.g. the configuration and don't have to adjust it in multiple different places and repos, if necessary. But the platform.ide product is already very minimal, there is not much one can remove more: But to be save we could also add the two features declared there and effectively just inherit the configuration. |
Test Results 765 files 765 suites 1h 5m 50s ⏱️ Results for commit e3e3a7c. ♻️ This comment has been updated with latest results. |
HannesWell
force-pushed
the
replace-sdk.test.ide
branch
4 times, most recently
from
ed89584 to
9a7352b
Compare
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <?pde version="3.5"?> | ||
|
|
||
| <product name="Eclipse SDK" uid="org.eclipse.sdk.test.ide" id="org.eclipse.sdk.ide" application="org.eclipse.ui.ide.workbench" version="4.37.0.qualifier" type="mixed" includeLaunchers="true" autoIncludeRequirements="true"> |
There was a problem hiding this comment.
If I recall correctly the includeLaunchers="true" was an important part here as the test want to find the launcher binary.
There was a problem hiding this comment.
Yes, but the platform product has it too:
https://github.com/eclipse-platform/eclipse.platform.releng.aggregator/blob/652aa77f5e2fb6e65bce0afd0cd31a8f65ea5ad5/eclipse.platform.releng.tychoeclipsebuilder/eclipse.platform.repository/platform.product#L4
In the latest state I have also changed the assumption if the executable can be found into an assertion and now we have many failures instead of skipped tests.
But on the master these tests are skipped as well. As you wrote in our private chat, this might be related to
I'll try and see if adding the equinox.executable feature helps.
There was a problem hiding this comment.
In the latest state I have also changed the assumption if the executable can be found into an assertion and now we have many failures instead of skipped tests.
But on the master these tests are skipped as well. As you wrote in our private chat, this might be related to
Moved the investigation and hopefully fix of that problem into
HannesWell
force-pushed
the
replace-sdk.test.ide
branch
from
9a7352b to
64ca74e
Compare
HannesWell
force-pushed
the
replace-sdk.test.ide
branch
from
64ca74e to
fce5ad2
Compare
Instead of own complete product definitions just use the existing o.e.platform.ide product and install all additionally required IUs while tycho-surefire assembles the test-runtime. In an earlier state the test-runtime was just provisioned from the 'o.e.sdk.ide' product, which had the drawback, that it included the o.e.pde feature from the latest I-build and not the one just built in the Maven reactor. Instead of the 'o.e.sdk.ide' product, now 'o.e.platform.ide' is used as base product. The latter doesn't contain the o.e.pde feature, which allows us to install it from the reactor when tycho-surefire assembles the test-runtime. Follow-up on - eclipse-pde#1149
HannesWell
force-pushed
the
replace-sdk.test.ide
branch
from
fce5ad2 to
e3e3a7c
Compare
3 participants
Instead of own complete product definitions just use the existing o.e.platform.ide product and install all additionally required IUs while
tycho-surefireassembles the test-runtime.In an earlier state the test-runtime was just provisioned from the
o.e.sdk.ideproduct, which had the drawback, that it included theo.e.pdefeature from the latest I-build and not the one just built in the Maven reactor.Instead of the
o.e.sdk.ideproduct, nowo.e.platform.ideis used as base product. The latter doesn't contain theo.e.pdefeature, which allows us to install it from the reactor whentycho-surefireassembles the test-runtime.Follow-up on